renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Enhance accessibility for toggle toolbar buttons. Issue #1581

Browse Source
This commit is contained in:
Maurice Parker
2020-01-09 14:38:25 -07:00
parent 75938a8153
commit 3115abc72e
4 changed files with 60 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
iOS/MasterTimeline/MasterTimelineViewController.swift
View File

@@ -112,10 +112,10 @@ class MasterTimelineViewController: UITableViewController, UndoableCommandRunner
// MARK: Actions
@IBAction func toggleFilter(_ sender: Any) {
if coordinator.isReadArticlesFiltered {
filterButton.image = AppAssets.filterInactiveImage
setFilterButtonToInactive()
coordinator.showAllArticles()
} else {
filterButton.image = AppAssets.filterActiveImage
setFilterButtonToActive()
coordinator.hideReadArticles()
}
}
@@ -579,9 +579,9 @@ private extension MasterTimelineViewController {
}
if coordinator.isReadArticlesFiltered {
filterButton.image = AppAssets.filterActiveImage
setFilterButtonToActive()
} else {
filterButton.image = AppAssets.filterInactiveImage
setFilterButtonToInactive()
}
tableView.selectRow(at: nil, animated: false, scrollPosition: .top)
@@ -599,6 +599,16 @@ private extension MasterTimelineViewController {
updateToolbar()
}
func setFilterButtonToActive() {
filterButton?.image = AppAssets.filterActiveImage
filterButton?.accLabelText = NSLocalizedString("Selected - Filter Read Articles", comment: "Selected - Filter Read Articles")
}
func setFilterButtonToInactive() {
filterButton?.image = AppAssets.filterInactiveImage
filterButton?.accLabelText = NSLocalizedString("Filter Read Articles", comment: "Filter Read Articles")
}
func updateToolbar() {
markAllAsReadButton.isEnabled = coordinator.isTimelineUnreadAvailable
firstUnreadButton.isEnabled = coordinator.isTimelineUnreadAvailable